feat: github actions to build browser extension for pull requests #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: test action
chore: test action
* testing PR * test * test * test * test * test * test * test * test * test
* testing PR * test * test * test * test * test * test * test * test * test * test
|
No worries about the multiple commits. Unfortunately there's no other way to test github actions, so this was expected :) i'll squash them into one commit so not a problem. Lets see if we can combine the two actions into 1. I think we could build the firefox and chrome version in the same action. So the build action could look something like Then configure the upload-artifact action : I think this would create one artifact zip files with two folders for each extension. |
|
I think the github actions are failing because we haven't given write access for |
duggalsu
pushed a commit
that referenced
this pull request
Oct 24, 2023
Builds the extension for firefox and chrome and adds a link to them under the PR comments section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR resolves #347.
This PR has the github action code to build the browser extension when a pull request is made to the
mainbranch oftattle-made/Uli.Once a user makes the PR, a comment (bot) will pop up having 2 links. One which contains the build folder for firefox and the other for chrome.
Steps to test the PR
mainbranch oftattle-made/Uli@dennyabrain apologies for the large number of commits, but every time to test a change in the action, I had to push the changes and make a PR to test them out.